Skip to content

Add two missing methods for VirtualPathProvider #562

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 11, 2024
Merged

Add two missing methods for VirtualPathProvider #562

merged 2 commits into from
Dec 11, 2024

Conversation

@Elderry
Copy link
Contributor

@Elderry Elderry commented Dec 10, 2024 •
edited
Loading

  • You've read the Contributor Guide and Code of Conduct.
  • You've included unit tests for your change, where applicable.
  • You've included inline docs for your change, where applicable.
  • There's an open issue for the PR that you are making. If you'd like to propose a new feature or change, please open an issue to discuss the change or find an existing issue.

PR Title
Add two missing methods for VirtualPathProvider

PR Description

  • GetCacheKey
  • OpenFile

@Elderry Elderry mentioned this pull request Dec 10, 2024
Closed
twsouthwick
twsouthwick approved these changes Dec 11, 2024
View reviewed changes
Copy link
Member

@twsouthwick twsouthwick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@twsouthwick twsouthwick merged commit 1712982 into dotnet:main Dec 11, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@twsouthwick twsouthwick twsouthwick approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Elderry @twsouthwick